infiniteopt / InfiniteOpt.jl

An intuitive modeling interface for infinite-dimensional optimization problems.
https://infiniteopt.github.io/InfiniteOpt.jl/stable
MIT License
251 stars 17 forks source link

Use New JuMP Macro API #334

Closed pulsipher closed 7 months ago

pulsipher commented 8 months ago

This tries out https://github.com/jump-dev/JuMP.jl/pull/3620 as a proof of concept.

cc @odow

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ad13a33) 99.76% compared to head (f78eabe) 99.74%.

Files Patch % Lines
src/macros.jl 98.79% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #334 +/- ## ========================================== - Coverage 99.76% 99.74% -0.02% ========================================== Files 36 36 Lines 6680 6589 -91 ========================================== - Hits 6664 6572 -92 - Misses 16 17 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

odow commented 8 months ago

The 1.6 failure is our fault, because we don't have <0.0.1 here: https://github.com/jump-dev/JuMP.jl/blob/5b1a53f0a5adb7028ec2356f6239657a21475891/Project.toml#L24

pulsipher commented 8 months ago

The 1.6 failure is our fault, because we don't have <0.0.1 here: https://github.com/jump-dev/JuMP.jl/blob/5b1a53f0a5adb7028ec2356f6239657a21475891/Project.toml#L24

Ok, I'll wait for the fix then.

odow commented 8 months ago

Ok, I'll wait for the fix then.

It's just because you're using Pkg in the tests. This is a bug in Julia 1.6. When we tag a release of JuMP it'll work.

Edit: I guess it doesn't hurt: https://github.com/jump-dev/JuMP.jl/pull/3626

odow commented 8 months ago

Hopefully fixed, so try re-running the tests.

pulsipher commented 8 months ago

Hopefully fixed, so try re-running the tests.

That seems to have fixed it, thanks!