search

infinitered / ProMotion-menu

RubyMotion gem allowing you to easily setup a facebook or Path style hidden slide menu easily with the ProMotion gem.
74 stars 29 forks source link

Allow the user to decide if the show/hide animates or not. #19

Closed markrickert closed 10 years ago

markrickert commented 10 years ago

Defaults to true.

macfanatic commented 10 years ago

Good work @markrickert - can you update the 1 failing spec we have, looks like this line is the culprit:

https://github.com/macfanatic/promotion_slide_menu/blob/master/spec/slide_menu_screen_spec.rb#L29

markrickert commented 10 years ago

huh... the test didn't fail locally for me so I added another test that makes sure things are shown immediately when requested.

macfanatic commented 10 years ago

Maybe the wait(0.1) isn't long enough for the animation to complete? Not sure why since we were animating by default before.... :)

markrickert commented 10 years ago

I checked it immediately on calling without animation and found i still had to wait the 0.1 seconds for the application to update the screen.

Nevertheless, this should be solid.