search

infinitered / ProMotion-menu

RubyMotion gem allowing you to easily setup a facebook or Path style hidden slide menu easily with the ProMotion gem.
74 stars 29 forks source link

ProMotion 1.0 #4

Closed dkrusenstrahle closed 11 years ago

dkrusenstrahle commented 11 years ago

Please make the slide menu compatible with latest version of ProMotion (1.0).

macfanatic commented 11 years ago

Would you be able to help out with this just by gathering a list of changes that we would need to deal with?

dkrusenstrahle commented 11 years ago

I don´t think there needs to be any changes other than changing the gemfile. Currently it locks ProMotion to 0.7.6. I get this error when I run bundle:

Bundler could not find compatible versions for gem "ProMotion": In Gemfile: pro_motion_slide_menu (>= 0) ruby depends on ProMotion (~> 0.7.6) ruby

ProMotion (1.0.0)
jamonholmgren commented 11 years ago

I'll look, @macfanatic .

jamonholmgren commented 11 years ago

Found a couple places where you're using controller.main_controller. Example: https://github.com/macfanatic/promotion_slide_menu/blob/master/lib/pro_motion_slide_menu/slide_menu_screen.rb#L43

Change that to:

      controller = controller.navigationController || controller

...and you should be good.

macfanatic commented 11 years ago

Awesome, have been out of RM land for a couple months now, miss using PM @jamonholmgren :)

jamonholmgren commented 11 years ago

We've been foolishly moving ahead without you, Matt. Looking forward to having you contribute again in the future. :D

macfanatic commented 11 years ago

5 provided this functionality, version 0.0.4 is now available.