search

infinitered / apisauce

Axios + standardized errors + request/response transforms.
MIT License
2.8k stars 184 forks source link

Include umd build in release #262

Closed eithe closed 3 years ago

eithe commented 3 years ago

In https://github.com/infinitered/apisauce/pull/260 I forgot that the new umd build also needs to be included in the package.json "files" section to be included in releases. Sorry about that @chakrihacker.

Any chance you could merge this, and release as 2.1.1 or something? Thanks again for considering!

chakrihacker commented 3 years ago

Sure, can you fix indentation

eithe commented 3 years ago

Sure, but looks ok here?

image

eithe commented 3 years ago

I know it's a very far stretch, but is there any chance this could be merged and released today? I'm having a workshop/hackathon tomorrow at work to showcase how to modernize our stack, and unfortunately I forgot to actually check that the 2.1.0 release worked before today.

Please let me know if there's anything I can do regarding the indentation comment, I might just be blind :)

chakrihacker commented 3 years ago

hey, sorry for the delay

infinitered-circleci commented 3 years ago

:tada: This PR is included in version 2.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

eithe commented 3 years ago

Works brilliantly, @chakrihacker. Thanks again for including :)