open doesn't use arguments/options

[mixflame]

if you look here https://github.com/infinitered/bluepotion/blob/70007244adc1a0c03924cd015104b30ac9e79ac6/lib/project/pro_motion/activities/pm_navigation_activity.rb#L26-L33

you can see nothing is done with the options

my current work around is to init the object, change the property and then call open

[jamonholmgren]

You're right. Should definitely be fixed. Seems like a straightforward pull request...want to give it a go, @jsilverMDX ? Something like:

options.each{|k, v| frag.send("#{k}=", v) if frag.respond_to?("#{k}=") }

[mixflame]

Yes, I will make a demo app and try to fix this before work today.

On Sat, Oct 17, 2015 at 11:53 AM, Jamon Holmgren notifications@github.com wrote:

You're right. Should definitely be fixed. Seems like a straightforward pull request...want to give it a go, @jsilverMDX https://github.com/jsilverMDX ? Something like:

options.keys.each{|k| frag.send("#{k}=", options[k]) if frag.respond_to?("#{k}=") }

— Reply to this email directly or view it on GitHub https://github.com/infinitered/bluepotion/issues/101#issuecomment-148937947 .

[mixflame]

Thanks @Jamon.

On Sat, Oct 17, 2015 at 4:35 PM, Jonathan Silverman jsilverman2@gmail.com wrote:

Yes, I will make a demo app and try to fix this before work today.

On Sat, Oct 17, 2015 at 11:53 AM, Jamon Holmgren <notifications@github.com

wrote:

You're right. Should definitely be fixed. Seems like a straightforward pull request...want to give it a go, @jsilverMDX https://github.com/jsilverMDX ? Something like:

options.keys.each{|k| frag.send("#{k}=", options[k]) if frag.respond_to?("#{k}=") }

— Reply to this email directly or view it on GitHub https://github.com/infinitered/bluepotion/issues/101#issuecomment-148937947 .

[jamonholmgren]

:+1:

[mixflame]

seems fixed to me.