search

infinitered / bluepotion

Like RedPotion, but for Android
MIT License
74 stars 18 forks source link

Fix PMHashBundle type checking for recent RubyMotion versions #125

Closed svicalifornia closed 7 years ago

svicalifornia commented 7 years ago

Newer versions of RubyMotion return short strings (e.g. String, Symbol) for class names in Java/Android. I've updated the type checking in PMHashBundle to add the shorter class names. Previously these shorter names were falling through the when conditions to cause "invalid type" exceptions.

twerth commented 7 years ago

I'm merging this, I don't current have the ability to review if it's all good though.

jamonholmgren commented 7 years ago

@svicalifornia Are you interested in helping maintain RedPotion, BluePotion, ProMotion, and others? We don't use much RubyMotion these days but would still like these libraries we worked so hard on to be kept up to date if possible.

svicalifornia commented 7 years ago

@jamonholmgren I may contribute more bug fixes if we encounter other issues. However, we're only using RubyMotion on one project and already started on migrating it to React Native.