search

infinitered / cdq

Core Data Query for RubyMotion
MIT License
172 stars 35 forks source link

Allow updates to an object for multiple properties. #115

Closed markrickert closed 9 years ago

markrickert commented 9 years ago

with specs and docs of course :)

jamonholmgren commented 9 years ago

:+1: :100:

citrus commented 9 years ago

This is awesome. Great work! 👍👍

dam13n commented 9 years ago

Just curious - is there a reason not to sanitize for the user by default?

markrickert commented 9 years ago

Trying to follow ActiveRecord's lead and raise an exception. If Ken has and strong feeling either way, I'm open to being pursuaded to change it.

kemiller commented 9 years ago

I don't have super-strong feelings one way or the other, but I slightly prefer your way, Mark.

markrickert commented 9 years ago

Yeah, I understand that sometimes you have things that get returned from an API or whatever that contain more properties than your actual data model, but I'm not keen on putting the cleansing burden on CDQ.

dam13n commented 9 years ago

Helpful to hear your explanations. Thanks.

no-itsbackpack commented 9 years ago

Hey @kemiller, is there any reason why this has not been merged yet ?

kemiller commented 9 years ago

Indolence, mostly. I think travis was being slow last time i looked at it, but there's no particular reason it can't be merged.

no-itsbackpack commented 9 years ago

:+1:

markrickert commented 9 years ago

WOOHOO!