search

infinitered / gluegun

A delightful toolkit for building TypeScript-powered command-line apps.
MIT License
2.95k stars 147 forks source link

Update new template #734

Closed fabien0102 closed 2 years ago

fabien0102 commented 3 years ago

fixes #737

Hello,

First of all, very nice project, this looks really amazing and I can't wait to try this framework on my projects 😁

This said, the new template looks a bit out-of-date, so this is my little contribution to this project

What's inside?

  1. Bump the main dependencies (jest, typescript, ts-node, …)
  2. Use copyfiles to be able to build the project on a windows machine
  3. Migrate ts-lint to eslint
  4. Add husky & pretty-quick to format on pre-commit
  5. Use import instead of require on typescript project (so eslint is happy)

How to test

fabien0102 commented 3 years ago

On CI: image

Locally: image

I guess I was just not lucky regarding the timeout 😕

fabien0102 commented 3 years ago

@jamonholmgren Can you help me on this failing CI? Not really sure why this is taking so much time…

jamonholmgren commented 3 years ago

@fabien0102 I apparently missed this PR, apologies. I'll be looking at it soon!

jamonholmgren commented 3 years ago

Can you push a new empty commit to this to restart the CI and see if it passes?

fabien0102 commented 3 years ago

Can you push a new empty commit to this to restart the CI and see if it passes?

I can, but will be tomorrow, no computer around ;) (but I think I already tried... But with a bit of luck 🤞)

fabien0102 commented 3 years ago

@jamonholmgren The CI is still failing…

jamonholmgren commented 2 years ago

This has taken me way too long to get to, @fabien0102, but it looks amazing. I'll be publishing a new version this week.

infinitered-circleci commented 2 years ago

:tada: This PR is included in version 5.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: