infinitered / gluegun

A delightful toolkit for building TypeScript-powered command-line apps.
MIT License
2.95k stars 147 forks source link

posibility of a 4.6.2 release with less strict ejs version dependency #739

Open paimon0715 opened 3 years ago

paimon0715 commented 3 years ago

Hi, @jamonholmgren, I'd like to report a vulnerability introduced by package ejs@2.7.4:

Issue Description

I noticed that a vulnerability is introduced in gluegun@4.6.1: Vulnerability SNYK-JS-EJS-1049328 affects package ejs (versions:<3.1.6): https://snyk.io/vuln/SNYK-JS-EJS-1049328 The above vulnerable package is referenced by gluegun@4.6.1 via: gluegun@4.6.1 ➔ ejs@2.7.4

Since gluegun@4.6.1 (14,538 downloads per week) is referenced by 98 downstream projects (e.g., solidarity 3.0.4 (latest version), @graphprotocol/graph-cli 0.21.1 (latest version), @shopware-pwa/cli 0.9.2 (latest version), @shopware-pwa/nuxt-module 0.9.2 (latest version), @dzlzv/hydra-cli 3.0.0 (latest version)), the vulnerability SNYK-JS-EJS-1049328 can be propagated into these downstream projects and expose security threats to them via the following package dependency paths: (1)@bethaged/orion-cli@1.0.44 ➔ gluegun@4.6.1 ➔ ejs@2.7.4 (2)@kraken.js/cli@0.0.6-1ce86fe ➔ gluegun@4.6.1 ➔ ejs@2.7.4 ......

If gluegun@4.6.* removes the vulnerable package from the above version, then its fixed version can help downstream users decrease their pain.

Given the large number of downstream users, could you help update your package to remove the vulnerability from gluegun@4.6.1 ?

Fixing suggestions

In gluegun@4.6.2, maybe you can try to perform the following upgrade : ejs ^2.6.1 ➔ ^3.1.6;

Note: ejs@3.1.6(>=3.1.6) has fixed the vulnerability SNYK-JS-EJS-1049328. Of course, you are welcome to share other ways to resolve the issue.^_^