Closed mikenikles closed 11 months ago
@mikenikles Do you know if we can just remove the extends NodeJS.EventEmitter
or do we also need to add the on()
method signature like the Commander folks did?
Commander only added the on()
method signature because it is part of the documented Commander API. .on()
may be used in client code. (And no other inherited EventEmitter methods are expected in client code.)
:tada: This issue has been resolved in version 5.1.5 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
I recently upgraded
@types/node
to16.11.11
and started to notice the following two errors.Expand to see logs
A fix that works in my environment, but I'd need a maintainer's input on this, is to remove
extends NodeJS.EventEmitter
from here and here.FWIW, I found the Commander folks ended up with the same fix for their project.