search

infinitered / gluegun

A delightful toolkit for building TypeScript-powered command-line apps.
MIT License
2.96k stars 147 forks source link

Add onAbort function to toolbox meta #752

Closed ugur-eren closed 2 years ago

ugur-eren commented 2 years ago

In my project I'm working with temporary files and needed this solution. And since there's an issue about it, I wanted to open a PR. (This is my first open-source PR, I'm sorry if there's an issue about it.)

I've never worked with signals before, let me know if I have a mistake that needs to be resolved. I've used the signals described in node.js and GNU documentation.

onAbort preview

Fixes #463

jamonholmgren commented 2 years ago

Great work @ugur-eren -- and congrats on your first open source PR! Hopefully one of many. :-)

infinitered-circleci commented 2 years ago

:tada: This PR is included in version 5.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ugur-eren commented 2 years ago

Thanks! I just noticed ci:test is failed. Is it my mistake? I can create a new typescript cli but I'm still not sure.

jamonholmgren commented 2 years ago

@ugur-eren I re-triggered the CI job. That's running on Windows, so you might want to take a look at it in Windows and see if there's something going on.

Just FYI, I'm on-stream working on putting Gluegun into a community-supported mode. Feel free to join if you want!