Patch RCTWebSocket (WIP)

[morgandonze]

This is based off this solution

to the issue correct library reference for libfishhook.a

[morgandonze]

PATCH DOESN'T APPLY

Update 3

The following is one issue that can prevent the patch from applying, but it is distinct from the problem related to the snippet I posted (Begin PBXBuildFile section). This issue is that

IPHONEOS_DEPLOYMENT_TARGET = 8.0;

can appear on a different line for no obvious reason.

Update 2

I tried using the current master branch version of andross, and the error has occurred again. SO, I'm thinking that caching may play a part in this. I'll make sure I nuke them every time.

Update

I'm thinking that changes to this file should just be expected, and this approach to fixing the problem just can't work long-term (or even medium-term). If I understand this situation, I should just consider the original patch I created to be obsolete now. Yes?

What I did:

1. ../ignite/bin/ignite new Puffin -b /Users/morgan/dev/ignite-dev-screens-missing/ignite-ir-boilerplate-andross
2. Answered 'no' to everything
3. cd Puffin
4. Checked ./ios/Puffin.xcodeproj/project.pbxproj to see if patch applied.
5. Noticed that project.pbxproj is different from the version on which the patch was based

Begin PBXBuildFile section

/* Begin PBXBuildFile section */
        00C302E51ABCBA2D00DB3ED1 /* libRCTActionSheet.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 00C302AC1ABCB8CE00DB3ED1 /* libRCTActionSheet.a */; };
        00C302E71ABCBA2D00DB3ED1 /* libRCTGeolocation.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 00C302BA1ABCB90400DB3ED1 /* libRCTGeolocation.a */; };
        00C302E81ABCBA2D00DB3ED1 /* libRCTImage.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 00C302C01ABCB91800DB3ED1 /* libRCTImage.a */; };
        00C302E91ABCBA2D00DB3ED1 /* libRCTNetwork.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 00C302DC1ABCB9D200DB3ED1 /* libRCTNetwork.a */; };
        00C302EA1ABCBA2D00DB3ED1 /* libRCTVibration.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 00C302E41ABCB9EE00DB3ED1 /* libRCTVibration.a */; };
        00E356F31AD99517003FC87E /* EagleTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 00E356F21AD99517003FC87E /* EagleTests.m */; };
        133E29F31AD74F7200F7D852 /* libRCTLinking.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 78C398B91ACF4ADC00677621 /* libRCTLinking.a */; };

Comment

I'm perplexed because (in my memory), I followed these same steps several times once I got the patch working, and it applied every time. I don't know why project.pbxproj is different all the sudden.

Environment

Andross version: commit ac1189c

 ⫸ ignite doctor
System
  platform           darwin
  arch               x64
  cpu                12 cores                                              Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  directory          /Users/morgan/dev/ignite-dev-screens-missing/Puffin

JavaScript
  node               8.11.4       /usr/local/bin/node
  npm                5.6.0        /usr/local/bin/npm
  yarn               1.9.4        /usr/local/bin/yarn

React Native
  react-native-cli   2.0.1
  app rn version     0.55.1

Ignite
  ignite             2.1.2        /usr/local/bin/ignite

The third line here should have been libfishhook:

[jamonholmgren]

@mlaco Does this issue persist with the latest React Native?

[jamonholmgren]

@mlaco I think we can close this one.