search

infinitered / ignite-andross

The original React Native boilerplate from Infinite Red - Redux, React Navigation, & more
https://infinite.red/ignite
MIT License
475 stars 151 forks source link

upgraded default react-native version #228

Closed lvlrSajjad closed 5 years ago

lvlrSajjad commented 5 years ago

upgraded default react-native version to 0.57.7

updated react-navigation to 3.0.0

also updated ignite-dev-screens,redux,redux-persist and some other libs to the last version

after changes i got it running in android and it was ok

removed allowFontScaling from boilerplate/App/Config/index.js cause it causes error in new react-native version

morgandonze commented 5 years ago

Thanks for the PR @lvlrSajjad.

Semaphoreci has some complaints:

standard: Use JavaScript Standard Style (https://standardjs.com)
standard: Run `standard --fix` to automatically fix some problems.
  /home/runner/ignite-ir-boilerplate-andross/boilerplate.js:181:30: Strings must use singlequote.
  /home/runner/ignite-ir-boilerplate-andross/boilerplate.js:181:61: Strings must use singlequote.
  /home/runner/ignite-ir-boilerplate-andross/boilerplate.js:183:5: Block must not be padded by blank lines.

Could you fix those please?

lvlrSajjad commented 5 years ago

Thanks for the PR @lvlrSajjad.

Semaphoreci has some complaints:

standard: Use JavaScript Standard Style (https://standardjs.com)
standard: Run `standard --fix` to automatically fix some problems.
  /home/runner/ignite-ir-boilerplate-andross/boilerplate.js:181:30: Strings must use singlequote.
  /home/runner/ignite-ir-boilerplate-andross/boilerplate.js:181:61: Strings must use singlequote.
  /home/runner/ignite-ir-boilerplate-andross/boilerplate.js:183:5: Block must not be padded by blank lines.

Could you fix those please?

yes taken care of but it says 

The `ignite generate` command must be run in an ignite-compatible directory

while it generates correctly it seems even in the main version of ignite-andross-boilerplate we have same error i've tested a clone and got same errors image

lvlrSajjad commented 5 years ago

in semaphore log it seems we getting errors like these

Yarn supports the following semver range: "^4.8.0 || ^5.7.0 || ^6.2.2 || >=8.0.0"\nerror react-native@0.57.5: The engine "node" is incompatible with this module. Expected version ">=8.3".\nerror Found incompatible module\n{ Error: Command failed: yarn add react-native@0.57.5
Command `yarn add react-native@0.57.5 --exact` failed

i think the semaphor's yarn/npm version is in incompatible with react-native@0.57.5.

in my system i can run this test at least the first one successfully passes .

image

lvlrSajjad commented 5 years ago

Just ignite-dev-screens may not work with this version of react-navigation (3.0.0) so if you merge this , i will upgrade the plugin too also i have semaphor's yarn version errors yet more info about errors Here and Here

morgandonze commented 5 years ago

@lvlrSajjad we're removing Semaphore from this project and adding Circle CI instead. We can ignore the Semaphore failure and see whether it passes on Circle once it's ready.

lvlrSajjad commented 5 years ago

@lvlrSajjad we're removing Semaphore from this project and adding Circle CI instead. We can ignore the Semaphore failure and see whether it passes on Circle once it's ready.

i just accidently closed the pull @mlaco i must fetch your circle config to being testable with circle ?

morgandonze commented 5 years ago

@lvlrSajjad yes, you'll need the circle config, but it looks like you got it already. We need to trigger Circle to test your branch. Please make an empty commit using git commit --allow-empty -m "fix(ci): Testing CI release" to do so.

lvlrSajjad commented 5 years ago

@lvlrSajjad yes, you'll need the circle config, but it looks like you got it already. We need to trigger Circle to test your branch. Please make an empty commit using git commit --allow-empty -m "fix(ci): Testing CI release" to do so.

@mlaco Well i've done the commit even multipletimes but no trigger happend

morgandonze commented 5 years ago

@lvlrSajjad you might need to create a new PR. Keep this one open, but can you also open a new one? I think it might trigger the build.

lvlrSajjad commented 5 years ago

@lvlrSajjad you might need to create a new PR. Keep this one open, but can you also open a new one? I think it might trigger the build.

when i try to create new pull request while this one open , i see this screen image

do you know a way to create new pr while still this one is open ? @mlaco

morgandonze commented 5 years ago

@lvlrSajjad I found the setting that will allow Circle to run the tests on PRs

lvlrSajjad commented 5 years ago

well it seems it can't find lint command in package.json of installed project . maybe it can't run ignite add standard

morgandonze commented 5 years ago

well it seems it can't find lint command in package.json of installed project . maybe it can't run ignite add standard

Yep. I'm currently trying to figure out why. It's able to do it on the master branch, so I'm kind of stumped.

lvlrSajjad commented 5 years ago

well it seems it can't find lint command in package.json of installed project . maybe it can't run ignite add standard

Yep. I'm currently trying to figure out why. It's able to do it on the master branch, so I'm kind of stumped.

i found problem it's something wrong with my react-navigation linking , i will cover it :-D @mlaco

morgandonze commented 5 years ago

Congrats, it worked!

morgandonze commented 5 years ago

Let me just look over the code again before I merge (I want to get a second review too)

lvlrSajjad commented 5 years ago

@mlaco Test passed but i need to find the problem with patch in file :-D cause i need to do that modifications on mainactivity.java as this link says https://reactnavigation.org/docs/en/getting-started.html

lvlrSajjad commented 5 years ago

Guys I'm done @mlaco thank's for being patient and helping me to figure this out @markrickert thank's for reviews

morgandonze commented 5 years ago

@lvlrSajjad yes, thank you! I appreciate your hard work and dedication.

infinitered-circleci commented 5 years ago

:tada: This PR is included in version 2.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: