search

infinitered / ignite-andross

The original React Native boilerplate from Infinite Red - Redux, React Navigation, & more
https://infinite.red/ignite
MIT License
475 stars 151 forks source link

StartupRedux should be in reducers in Redux/index.js #240

Closed hunwalk closed 5 years ago

hunwalk commented 5 years ago

Hey. I've recently discovered that StartupRedux is not in the default reducers at App/Redux/index.js Why is it so? :D

Today i've extended the startupSaga and the startupRedux but after a yield put(StartupActions.startupAction(someData)) nothing happened. Not even a single error.

jamonholmgren commented 5 years ago

@GantMan ^^

GantMan commented 5 years ago

That Reducer is for actions on app load. So it's referenced directly here:

https://github.com/infinitered/ignite-andross/blob/master/boilerplate/App/Containers/RootContainer.js#L5

Though it makes sense to include in the index, it's really only meant to dispatch once on application start, and other reducers take it from there. Moving it to the index is technically correct, but ineffectual.

I hope this helps!