infinitered / ignite-andross

The original React Native boilerplate from Infinite Red - Redux, React Navigation, & more
https://infinite.red/ignite
MIT License
475 stars 151 forks source link

A pull request for RN 0.58.3 support #248

Closed glaceglace closed 5 years ago

glaceglace commented 5 years ago

Upgrade to 0.58.3 Fix a middleWare method call error

jamonholmgren commented 5 years ago

I'm checking the ci issues now.

jamonholmgren commented 5 years ago

Just update this patch and the CI will pass:

diff --git a/package.json b/package.json
index 8ae6ba6..e0064a7 100644
--- a/package.json
+++ b/package.json
@@ -23,11 +23,12 @@
     "url": "https://github.com/infinitered/ignite-andross"
   },
   "scripts": {
+    "check-ignite": "which ignite # Checking if Ignite CLI is installed globally",
     "lint": "standard",
     "test": "jest",
     "watch": "jest --runInBand --watch",
     "coverage": "jest --runInBand --coverage",
-    "ci:test": "yarn test",
+    "ci:test": "yarn check-ignite && yarn test",
     "ci:publish": "yarn semantic-release",
     "semantic-release": "semantic-release"
   },
diff --git a/test/generators-integration.test.js b/test/generators-integration.test.js
index 0191f6b..65683f5 100644
--- a/test/generators-integration.test.js
+++ b/test/generators-integration.test.js
@@ -27,6 +27,7 @@ describe('generators', () => {
     process.chdir(tempy.directory())
     await execa(IGNITE, ['new', APP, '--min', '--skip-git', '--boilerplate', BOILERPLATE])
     process.chdir(APP)
+    await execa('npm', ['run', 'fixcode'])
   })

   test('generates a component', async () => {
glaceglace commented 5 years ago

The latest commits update ramda and replace merge() of ramda by mergeDeepRight() to fix the issus that newer versions in package.json.ejs could not be copied to the project generated by ignite cli.
And the old version of react-native-device-info module results in a build error for android