search

infinitered / ignite-andross

The original React Native boilerplate from Infinite Red - Redux, React Navigation, & more
https://infinite.red/ignite
MIT License
475 stars 150 forks source link

react-navigaton-drawer Issue #258

Open JuxhinB opened 5 years ago

JuxhinB commented 5 years ago

Current I have Ignite version 2.2.2 and I was having an issue while modifying drawerLockMode for a screen. By setting react-navigation fixed to version 3.0.0 also keeps react-navigation-drawer to 1.0.1 which is responsible to the issue. The solution of this issue is simple but it is a struggle to find from where the issue comes.

jamonholmgren commented 5 years ago

Hi @JuxhinB, thanks for submitting the issue! Are you using Ignite Andross or Bowser?

If Andross, the relevant line of code to update is here:

https://github.com/infinitered/ignite-andross/blob/495764631e34b0027bac76d8f523c4ebbad97f87/boilerplate.js#L177

If Bowser, it's this line:

https://github.com/infinitered/ignite-bowser/blob/941a1fe8f9c56d0e4cd44281f86eb6cb6cbece06/boilerplate/package.json.ejs#L39

If you could also post the results of ignite doctor that would help.

Getting react-navigation to the latest version would be really helpful.

JuxhinB commented 5 years ago

Hi! I'm using the Andross template, but the issue persist with some other react-navigation-drawer issues but ofc not related to this issue. My suggestion was to fix what you ship, since it is expected that sth out of the box should work fine.

kevinvangelder commented 5 years ago

@JuxhinB We do try to keep our code in good working order, but Andross has been deprecated.

JuxhinB commented 5 years ago

@kevinvangelder Thank for your reply ! Are you planning to totally discontinue the project? If not how can i help? I have been using Ignite recently and I'm really benefiting from it and in my opinion also others to because Ignite gives a good head-start.

kevinvangelder commented 5 years ago

We're planning to continue supporting Ignite (and it's current boilerplates) for the foreseeable future, however Andross has been replaced by Bowser. If you still need to use the tech stack of Andross we'll gladly review PRs, but we're only actively contributing to Bowser as all of our current projects were generated with the newer Bowser boilerplate.

jamonholmgren commented 5 years ago

To clarify, Andross isn't per se "deprecated", but is in "community support" which means that Infinite Red will:

  1. Review issues (usually within about 14 days)
  2. Review pull requests and provide feedback
  3. Merge pull requests
  4. Create new builds/releases

We will not:

  1. Actively build new features
  2. Actively fix bugs (usually -- some exceptions)
  3. Guarantee a response or turnaround time

If you need better support for your Andross-powered project, we are more than happy to contract with you to do so. That's how we make money to pay the bills, after all. :grin:

Hope this helps!