infinitered / ignite-andross

The original React Native boilerplate from Infinite Red - Redux, React Navigation, & more
https://infinite.red/ignite
MIT License
475 stars 151 forks source link

Example gives cannot read property 'includes' of undefined #294

Open kopax opened 4 years ago

kopax commented 4 years ago

Hi, I have just discover ignite and wanted to give it a try.

First of all, this example is not working, it gives โœ– Cannot read property 'includes' of undefined

dka@dev-11:[~/workspace/tmp]: npm i -g ignite-cli
npm WARN npm npm does not support Node.js v13.0.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11, 12.
npm WARN npm You can find the latest version at https://nodejs.org/
/home/dka/.nvm/versions/node/v13.0.1/bin/ignite -> /home/dka/.nvm/versions/node/v13.0.1/lib/node_modules/ignite-cli/bin/ignite
+ ignite-cli@3.2.2
added 190 packages from 138 contributors in 31.979s
dka@dev-11:[~/workspace/tmp]: ignite new PizzaApp
-----------------------------------------------
  (                  )   (                   
  )\ )   (        ( /(   )\ )    *   )       
 (()/(   )\ )     )\()) (()/(  ` )  /(   (   
  /(_)) (()/(    ((_)\   /(_))  ( )(_))  )\  
 (_))    /(_))_   _((_) (_))   (_(_())  ((_) 
 |_ _|  (_)) __| | \| | |_ _|  |_   _|  | __|
  | |     | (_ | | .` |  | |     | |    | _| 
 |___|     \___| |_|\_| |___|    |_|    |___|
-----------------------------------------------

An unfair headstart for your React Native apps.
https://infinite.red/ignite

-----------------------------------------------

๐Ÿ”ฅ igniting app PizzaApp
โœ” Which boilerplate would you like to use? ยท ignite-andross
โœ” using the Infinite Red boilerplate v2 (code name 'Andross')
โœ” added React Native 0.59.9 in 161.62s
โœ” Would you like Ignite Development Screens? ยท Yes
โœ” What vector icon library will you use? ยท react-native-vector-icons
โœ” What internationalization library will you use? ยท react-native-i18n
โœ” What animation library will you use? ยท react-native-animatable
โœ” Would you like to include redux-persist? ยท Yes
โœ” added ignite-andross in 7.46s
โœ” added ignite-vector-icons in 18.65s
โœ” added ignite-i18n in 14.92s
โœ” added ignite-animatable in 13.56s
โœ” added ignite-dev-screens in 21.49s
โœ” added ignite-redux-persist in 27.5s
โœ” added ignite-standard in 59.54s
โœ” configured git
โœ” ignited PizzaApp in 431.72s

    Ignite CLI ignited PizzaApp in 431.72s

    To get started:

      cd PizzaApp
      react-native run-ios
      react-native run-android

To run in Android, make sure you've followed the latest react-native setup instructions at https://facebook.github.io/react-native/docs/getting-started.html before using ignite.
You won't be able to run react-native run-android successfully until you have.
      ignite --help

    Read the walkthrough at https://github.com/infinitered/ignite-andross/blob/master/readme.md#boilerplate-walkthrough

    Need additional help? Join our Slack community at http://community.infinite.red.

    Now get cooking! ๐Ÿฝ

โœ” npm i complete
dka@dev-11:[~/workspace/tmp]: ignite add maps
โœ– Cannot read property 'includes' of undefined

Also, I see that ignite installed react-native 0.59.9 which is quite old. Are they plan to upgrade or can we already upgrade to >= 0.60.0 ?

Thanks for sharing!

kopax commented 4 years ago

Also have this:

dka@dev-11:[~/workspace/tmp]: ignite add i18n
โœ– Cannot read property 'includes' of undefined

Looking at https://github.com/AlexanderZaytsev/react-native-i18n , it seems that the package is deprecated

This library is deprecated in favor of react-native-localize. You can use react-native-localize with I18n-js (but also with react-intl, react-i18next, etc. The choice is yours!)

jamonholmgren commented 4 years ago

Hey @kopax , thanks for the issue! As Andross is in community support, we'd love a PR to fix this issue.