RN 0.63 and navigation 4.0.0

infinitered / ignite-andross

The original React Native boilerplate from Infinite Red - Redux, React Navigation, & more

https://infinite.red/ignite

MIT License

475 stars 151 forks source link

RN 0.63 and navigation 4.0.0 #309

Closed SandeshVakale closed 4 years ago

jamonholmgren commented 4 years ago

@SandeshVakale Do you know why the tests are failing in CI? Do they pass locally?

SandeshVakale commented 4 years ago

Hello @jamonholmgren , I changed node version. now test are passed. If you have any other changes, let me know. Else you can Merge my pull request. thanks

DeVoresyah commented 4 years ago

@SandeshVakale thanks for updating to RN 0.63 I've a question about the navigation, does react-navigation v5 still not stable so we just stay at version 4?

infinitered-circleci commented 4 years ago

:tada: This PR is included in version 4.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jamonholmgren commented 4 years ago

Great job @SandeshVakale !

SandeshVakale commented 4 years ago

thanks @jamonholmgren