search

infinitered / ignite-bowser

Bowser is now re-integrated into Ignite CLI! Head to https://github.com/infinitered/ignite to check it out.
https://infinite.red/ignite
MIT License
615 stars 140 forks source link

Use createNativeStackNavigator from react-native-screens #330

Closed harrisrobin closed 4 years ago

harrisrobin commented 4 years ago

This PR uses createNativeStackNavigator from react-native-screens instead of @react-navigation/native (now deprecated and moved to react-native-screens).

jamonholmgren commented 4 years ago

Thanks @harrisrobin ! <3

infinitered-circleci commented 4 years ago

:tada: This PR is included in version 5.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

vantuan88291 commented 4 years ago

i dont know the reason but on some android device, it make slow and lag when the first time app open. I have moved to @react-navigation/stack it's work fine. I tested on sony xzs android 8

jamonholmgren commented 4 years ago

Yeah, it might make sense to only use the native stack on iOS and use the non-native on Android. @harrisrobin did that, I think?

harrisrobin commented 4 years ago

Yeah, it might make sense to only use the native stack on iOS and use the non-native on Android. @harrisrobin did that, I think?

Yes that’s what I ended up doing but I also haven’t tested the latest versions of react-native-screens. Might be worth upgrading that and see if it improves android perf before you do so. Otherwise, i would export JS stack for android. I usually create a little helper function to handle that so the changes are minimal when switching between the two.

E.G:

const createStack = Platform.select({
 ios: createNativeStackNavigator,
 android: createStackNavigator
})

Haven't tested this code and just wrote it quickly, but that's what I'd expect it to look like.