Remove React.FunctionComponent from codebase

infinitered / ignite-bowser

Bowser is now re-integrated into Ignite CLI! Head to https://github.com/infinitered/ignite to check it out.

https://infinite.red/ignite

MIT License

615 stars 140 forks source link

Remove React.FunctionComponent from codebase #358

Closed ayshiff closed 4 years ago

ayshiff commented 4 years ago

What's going on?

We should remove React.FC / React.FunctionComponent from the codebase.
It was removed from the TypeScript template of create-react-app to avoid inciting to use it. More details in the GitHub issue: https://github.com/facebook/create-react-app/pull/8177/

In particular:

children props implicitly added, even when we don't want it
No support for Generic Type

Possible Implementation

carbon (7)

jamonholmgren commented 4 years ago

I agree with this.

https://twitter.com/erikras/status/1274391455210094599