Nice Feature Idea - Scrub GIF

infinitered / nsfwjs

NSFW detection on the client-side via TensorFlow.js

https://nsfwjs.com/

MIT License

7.94k stars 529 forks source link

Nice Feature Idea - Scrub GIF #79

Closed GantMan closed 5 years ago

GantMan commented 5 years ago

It would be pretty cool if when you scubbed the victory bar for a GIF, the associated GIF frame was shown. This can happen by having an option passed in for a reference to the SuperGIF and then using move_to(index). If you don't want the supergif, it's set to NULL in memory like it is currently.

I'd love to see why a particular frame is misclassified!

GantMan commented 5 years ago

@xilaraux - sorry I took your last ticket, would you want this one?

xilaraux commented 5 years ago

@GantMan don't be sorry :) I can handle it, but it will take a while for me.

GantMan commented 5 years ago

Awesome! Off the top of my head here's a simple implementation:

classifyGif takes options. One option is an object to store the SuperGif
When you use this option, SuperGif is not set to null in classifyGif
The web page now has a reference tot he SuperGif
Victory Bar Charts can have an onHover event described in their docs. Add that to the existing GifBar
The onHover calls the SuperGif move_to(i) - I think plus 1 - check index off by one possibility here

TADAAAAAAA 🎉

xilaraux commented 5 years ago

You almost did it. I will implement it. :) I don't understand one thing. Should the frame be displayed next to this text or somewhat separately?

GantMan commented 5 years ago

Hahahaha.

So I think if you call GifReference.move_to(i) the GIF they dropped will lock to that frame. No need to show it anywhere. Basically it will stop animating and move to that frame. I think.... :) Once you start experimenting it should be clear. Then when you stop mousing over the graph, it would be cool if it went back to animating.

GantMan commented 5 years ago

@xilaraux - how goes it?

xilaraux commented 5 years ago

@GantMan You can see the progress here - #83 I want to propose to name SuperGif object as gifControl and setGitControl and prop in config. What do you think? Also, I have doubts about the way I am setting this object and saving if to the React state, but spoiling the window is not an option neither. Looking forward to your review :) Sorry for the delay.

GantMan commented 5 years ago

Looks great, I updated your contributor status in the readme: https://github.com/infinitered/nsfwjs/commit/5413bd0e8541e3bf555a355712ef0959d3e0f04e