Closed trevor-coleman closed 5 months ago
Latest commit: 89d937c948b31b8954251ac82e8736fa427c9a8b
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
This looks pretty straightforward, how do these version pins work on android. For example you lifted the one on iOS for image labeling, but build.gradle contains
implementation 'com.google.mlkit:image-labeling:17.0.7' implementation 'com.google.mlkit:image-labeling-custom:17.0.1'
Do we have work to do there as well?
I updated all packages to the platform specific equivalent of ^17.0.0
(or whatever the major version was)
Figured it was safer than floating everything.
I updated all packages to the platform specific equivalent of ^17.0.0 (or whatever the major version was)
This caused problems with cocoapods, so I unpinned that side. The android side seems to do better with the versioning.
Updated with separate build scripts for CI.
#build with '--watch' and use the Turbo UI
yarn build
# just build, no watching
yarn build:ci
There were a couple issues blocking this that I had to resolve:
let logger = Logger()
withlet logger = Logger(logHandlers: [createOSLogHandler(category: Logger.EXPO_LOG_CATEGORY)])
expo-build-settings
to set theminimumDeploymentTarget
andcompileSDKVersion
inapp.json
tsconfig
packageyarn.lock
and resinstalled.To test: