search

infinitered / reactotron-redux

The redux plugin for reactotron that allows tracking redux actions and state
MIT License
10 stars 3 forks source link

Proposal: Use default import instead #11

Open gsklee opened 5 years ago

gsklee commented 5 years ago

Right now to set up a Redux & Redux Saga aware Reactotron instance, the import signatures will be something like:

import Reactotron from 'reactotron-react-native';
import { reactotronRedux } from 'reactotron-redux';
import sagaPlugin from 'reactotron-redux-saga';

I feel like there is something wrong with the inconsistency here and would like to suggest a better alternative:

import Reactotron from 'reactotron-react-native';
import ReactotronRedux from 'reactotron-redux';
import ReactotronReduxSaga from 'reactotron-redux-saga';

This will be a pure semantic and version breaking change. @rmevans9 if you are up for it (ie. unifying all the import semantics) I can create a PR to each and all Reactotron plugins.

rmevans9 commented 5 years ago

I am 100% behind this. I am wondering if it makes sense to export as default in addition to a named export on a .1 release then follow up a little bit later with a major bump dropping the named export to give users a migration path that doesn't force them into it immediately.