infinitered / reactotron-redux

The redux plugin for reactotron that allows tracking redux actions and state
MIT License
10 stars 3 forks source link

Possible issue with the library: object.entries requires that input parameters #15

Open obsidianart opened 5 years ago

obsidianart commented 5 years ago

ISSUE

PathObject.ts can return undefined but subscriptionsHandler.ts crash if it returns undefined on ...Object.entries(values).map(val => ({, since entries can't be called on undefined.

if we say if (starredPath && cleanedPath && values) { the app seems to work but I'm not sure why no one else is having the issue

Logging out those vars

 LOG  cleanedPath 
 LOG  starredPath false
 LOG  pathObject [Function pathObject]
 LOG  pathObjectOutcome undefined
 LOG  cleanedPath use
 LOG  starredPath false
 LOG  pathObject [Function pathObject]
 LOG  pathObjectOutcome undefined
 LOG  cleanedPath .
 LOG  starredPath false
 LOG  pathObject [Function pathObject]
 LOG  pathObjectOutcome undefined
 LOG  cleanedPath user
 LOG  starredPath false
 LOG  pathObject [Function pathObject]

Versions

This started happening after updating all libs, out of 2 projects with (likely) the same versions only one is crashing

    "react-navigation": "4.0.10",
    "react-navigation-redux-helpers": "4.0.1",
    "react-navigation-stack": "^1.9.3",
    "redux-persist": "6.0.0",
obsidianart commented 4 years ago

I`ve solved this problem only by adding true to createEnhancer(), so Reactotron.createEnhancer(true) . Up to you if you want to close this or not.

ghost commented 4 years ago

However, by doing this, none of the state subscriptions do work after adding true tocreateEnchancer.

fukhaos commented 4 years ago

Works using the last beta version of Reactotron

BoKKeR commented 4 years ago

I am still facing this issue after updating to "reactotron-redux": "^3.1.3". Did a full reinstallation including pod updates.

createEnhancer(true) helps but as said before the subscriptions stop working with it.

xilin commented 2 years ago

Should be related to the version of reactotron you use