Contribution documentation?

[kirakik]

Hello!

I'd love to get started on contributing! I forked the project, ran yarn welcome, but I'm getting some issues. Here's my stack trace:

$ lerna clean --yes
lerna info version 2.11.0
lerna info clean removing /Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/demo-react-js/node_modules
lerna info clean removing /Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/demo-react-native/node_modules
lerna info clean removing /Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/reactotron-apisauce/node_modules
lerna info clean removing /Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/reactotron-app/node_modules
lerna info clean removing /Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/reactotron-core-client/node_modules
lerna info clean removing /Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/reactotron-core-server/node_modules
lerna info clean removing /Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/reactotron-mst/node_modules
lerna info clean removing /Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/reactotron-react-js/node_modules
lerna info clean removing /Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/reactotron-react-native/node_modules
lerna info clean removing /Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/reactotron-redux-saga/node_modules
lerna info clean removing /Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/reactotron-redux/node_modules
lerna success clean finished
$ lerna bootstrap
lerna info version 2.11.0
lerna info Bootstrapping 11 packages
lerna info lifecycle preinstall
lerna info Installing external dependencies
lerna ERR! execute callback with error
lerna ERR! Error: Command failed: yarn install --mutex network:42424 --non-interactive --ignore-engines
lerna ERR! warning Waiting for the other yarn instance to finish (20308)
lerna ERR! error An unexpected error occurred: "ENFILE: file table overflow, scandir '/Users/kenza/Library/Caches/Yarn/v1/npm-core-js-2.5.1-ae6874dc66937789b80754ff5428df66819ca50b/modules/library'".
lerna ERR! [1/4] Resolving packages...
lerna ERR! [2/4] Fetching packages...
lerna ERR! [3/4] Linking dependencies...
lerna ERR! info If you think this is a bug, please open a bug report with the information provided in "/Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/reactotron-core-server/yarn-error.log".
lerna ERR! info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
lerna ERR!
lerna ERR!     at Promise.all.then.arr (/Users/kenza/Desktop/LetsReact/Open Source/reactotron/node_modules/execa/index.js:236:11)
lerna ERR!     at <anonymous>
lerna WARN complete Waiting for 3 child processes to exit. CTRL-C to exit immediately.
{ Error: Command failed: yarn install --mutex network:42424 --non-interactive --ignore-engines
warning Waiting for the other yarn instance to finish (20308)
error An unexpected error occurred: "ENFILE: file table overflow, scandir '/Users/kenza/Library/Caches/Yarn/v1/npm-core-js-2.5.1-ae6874dc66937789b80754ff5428df66819ca50b/modules/library'".
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
info If you think this is a bug, please open a bug report with the information provided in "/Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/reactotron-core-server/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

    at Promise.all.then.arr (/Users/kenza/Desktop/LetsReact/Open Source/reactotron/node_modules/execa/index.js:236:11)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
  code: 1,
  killed: false,
  stdout: '[1/4] Resolving packages...\n[2/4] Fetching packages...\n[3/4] Linking dependencies...\ninfo If you think this is a bug, please open a bug report with the information provided in "/Users/kenza/Desktop/LetsReact/Open Source/reactotron/packages/reactotron-core-server/yarn-error.log".\ninfo Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.\n',
  stderr: 'warning Waiting for the other yarn instance to finish (20308)\nerror An unexpected error occurred: "ENFILE: file table overflow, scandir \'/Users/kenza/Library/Caches/Yarn/v1/npm-core-js-2.5.1-ae6874dc66937789b80754ff5428df66819ca50b/modules/library\'".\n',
  failed: true,
  signal: null,
  cmd: 'yarn install --mutex network:42424 --non-interactive --ignore-engines',
  timedOut: false,
  exitCode: 1 }
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Am I missing a global dependency to set this up correctly?

Thank you!

[rmevans9]

It seems like you might be running into a issue similar to these:

https://github.com/reactioncommerce/reaction/issues/1938 https://github.com/meteor/meteor/issues/8057

Here is a yarn issue about this: https://github.com/yarnpkg/yarn/issues/2432

I would suggest trying a few of the options in those issues. Probably start by looking at the issue on the yarnpkg repo.

[kirakik]

Hey @rmevans9, thanks for the quick answer! The fix in reactioncommerce/reaction#1938 worked!

I still think it could be great to have a documentation for contributing. I'm going through the codebase right now to figure things out, but I think my first contribution might be just a simple guide to get started as a contributor :)

[rmevans9]

I am glad to hear that it worked for you!

That sounds like a great contribution. If you run into any issues feel free to hop on the slack listed in the readme. There is a specific reactotron channel there where you can reach both Steve and I.

[robinheinze]

@kirakik Looks like https://github.com/infinitered/reactotron/blob/master/docs/contributing.md was added recently but only covers installation right now, so I'm sure anything you want to add to that would be welcome! I'll also make sure that gets linked from the main README!

[rmevans9]

I am going to close this for now since the original issue is resolved. As for docs - if there are specific areas you want improved feel free to open an issue so we can track it. Thanks!