search

infinitered / redpotion

We believe iPhone development should be clean, scalable, and fast with a language that developers not only enjoy, but actively choose. With the advent of Ruby for iPhone development the RubyMotion community has combined and tested the most active and powerful gems into a single package called RedPotion
MIT License
233 stars 40 forks source link

Detect pointer type and remove exception catching #127

Closed bmichotte closed 9 years ago

bmichotte commented 9 years ago

It's faster to get the pointer type using this trick and it also remove the exception

This "trick" is also used in rubymotion samples (https://github.com/HipByte/RubyMotionSamples/commit/a437b8406f01f113b2dc468c0d6bddeb69ebd15f)

squidpunch commented 9 years ago

sweet, thanks @bmichotte

markrickert commented 9 years ago

Can someone check that the tests pass on an iPhone 4S device? I think that was why we went with the other solution previously but this looks like it will handle it properly. The 4S architecture was the problem with the pointer types.

markrickert commented 9 years ago

(I think)

squidpunch commented 9 years ago

I'll run the suite in a bit just to be sure.

bmichotte commented 9 years ago

I can't run the tests on my 4S, don't know why, but i've an app with this code which runs on 4S

squidpunch commented 9 years ago

Oh you said device, I don't have a 4s actual device but sounds like but sounds like @bmichotte has run it on the actual device.

bmichotte commented 9 years ago

@squidpunch and this code runs also on a app available on the appstore :)