search

infinitered / rmq

RMQ - RubyMotionQuery
MIT License
307 stars 52 forks source link

Fix infinite loop bug introduced with iOS 10 #329

Closed andrewhavens closed 8 years ago

andrewhavens commented 8 years ago

In one of my apps, upgrading to iOS 10 started resulting in a crash. After looking into it, I found that the problem was resulting from an infinite loop when trying to determine the current view controller. Specifically, in my case, I was presenting a UIImagePickerController from a navigation controller that was already being presented as a modal. Not sure if it had anything to do with either of those things, but I know that requesting the presentedViewController instead of the visibleViewController solved the issue.

markrickert commented 8 years ago

Yeah, you can see that there was a problem like this in ProMotion as well - https://github.com/infinitered/ProMotion/pull/796

Someone else want to put eyes on this @twerth @GantMan @jamonholmgren ... lgtm. Maybe merge this and #316 & #328 and release a new version?