search

infinitered / solidarity-react-native

Solidarity snapshot plugin for React Native projects
MIT License
48 stars 10 forks source link

Check ANDROID_SDK_ROOT instead of ANDROID_HOME? #22

Open TheAlmightyBob opened 6 years ago

TheAlmightyBob commented 6 years ago

According to https://developer.android.com/studio/command-line/variables.html, ANDROID_HOME is deprecated.

(however, I'm not sure when it was deprecated, or if HOME was intentionally chosen for compatibility reasons?)

Could the rule check both? i.e. just check that at least one of the two is defined?

GantMan commented 6 years ago

Good question.

I'm going to continue with what's required by the official React Native docs for now. When that changes, I'll switch this over.