Add emulator support - Githubissues

infinitered / solidarity-react-native

Solidarity snapshot plugin for React Native projects

MIT License

48 stars 10 forks source link

Add emulator support #26

Open DanielMSchmidt opened 6 years ago

DanielMSchmidt commented 6 years ago

Hi there,

I would like to be able to make assertions on android emulators available on the system. I plan to add a config that allows me to

specify that there should be an emulator with a given name
specify that there should be an emulator with an sdk version
a mix of the above

I have a couple of questions before starting to work on this:

Would it make sense to extract android stuff and make this co-dependent on the other module? It seems like android devs could benefit from it as well.
Do you think an important property of emulators is missing?

morgandonze commented 5 years ago

Hey @DanielMSchmidt sorry for the delayed response. Yours is an interesting idea.

I think it would make sense to write it as a plugin, and you could probably combine both Android and iOS. That's just my opinion.

I'm sorry I don't know what you mean by Do you think an important property of emulators is missing?. Are you asking whether adding the ability to make assertions about emulators would be useful?

@GantMan do you have anything to add?

DanielMSchmidt commented 5 years ago

I'm sorry I don't know what you mean by Do you think an important property of emulators is missing?. Are you asking whether adding the ability to make assertions about emulators would be useful?

I was referring to

specify that there should be an emulator with a given name
specify that there should be an emulator with an sdk version

and wondered if there is more area that should be covered in the plugin to be really useful

tabrindle commented 5 years ago

Hey all - the existing info we have on Android SDKs come from envinfo.

  SDKs:
    iOS SDK:
      Platforms: iOS 11.0, macOS 10.13, tvOS 11.0, watchOS 4.0
    Android SDK:
      Build Tools: 27.0.3
      API Levels: 26

It is conceivable that we could add emulators to envinfo, and thus solidarity. I will look into and post back here.

GantMan commented 5 years ago

@DanielMSchmidt - sorry for the delay. I've been traveling!

I like the idea of adding rules that allow you to specify emulators, such a PR would be accepted.

On Android, one strange thing to include is that they might use genymotion?

Anyhow, I expect whatever you come up with would be best.

tabrindle commented 5 years ago

Here is a sample of something I am working on in envinfo - is this what y'all are looking for?

  SDKs:
    iOS SDK:
      Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
    Android SDK:
      API Levels: 28
      Build Tools: 28.0.3
      System Images: android-28 | Google Play Intel x86 Atom

DanielMSchmidt commented 5 years ago

@tabrindle Yeahm pretty much :)

tabrindle commented 5 years ago

ok this is in envinfo 5.12.0.

test it out npx envinfo@latest --sdks

@GantMan Correct me if I'm wrong, we will need to add this upstream in Solidarity first.

GantMan commented 5 years ago

intermediate release

Solidarity 2.3.1 and solidarity-react-native 2.1.0

Please give this a go. I'm still adding/making features for Solidarity 3.0, so I did these minor releases.