search

infinitered / solidarity-react-native

Solidarity snapshot plugin for React Native projects
MIT License
48 stars 10 forks source link

Check for Java Version #27

Open ammichael opened 5 years ago

ammichael commented 5 years ago

Hi there!

First, this plugin is incredible. Thanks for that! It would be very useful if it checks Java version as well. I tried adding it myself but couldn't get it working since Java doesn't use semver and I'm not sure how to make it read the cli output to check it.

Being the output java version "1.8.0_171", is it possible to check it?

tabrindle commented 5 years ago

This is certainly possible given the underlying module envinfo returns java version. I think this is a good thing to add.

ammichael commented 5 years ago

It definitely would be useful. I've seen tons of issues happening because of wrong java version

angelcustodio commented 5 years ago

Same here. Impossible to check and would be great to have it since Java SDK is a must when developing for Android :(