Fix basic rule logic, typo

is343 commented 5 years ago

I cannot get the ANDROID_HOME env rule to pass. I notice that ANDROID_HOME is optional in envinfo, but I'm not sure what I can do to fix this rule, since I don't have the ANDROID_HOME path set up on my system.

If I delete the ANDROID_HOME env rule, I can get it working. The React Native custom rule now runs.

In react-native.js:

added await because getAndroidEnvData() returns a Promise. This fixes the ./android/app/build.gradle not found error.
I cannot get the report section of this rule to print when I run solidarity report

In getAndroidEnvData.js:

I updated androidData to make it more clear where the object is coming from. getAndroidSDKInfo() returns the array
```
[ 'Android SDK',
{ 'API Levels': [... ],
'Build Tools': [ ... ],
'System Images': [ ... ],
}
]
```

README typo fix:

yarn add global solidarity-react-native => yarn global add solidarity-react-native

is343 commented 5 years ago

@GantMan infinitered/solidarity#234 I made a few fixes to get the React Native rule passing. However, it's not coming up at all in the report.

I also don't know how I can go about fixing the ANDROID_HOME env rule. I imagine that will have to be done in solidarity, and not the plugin. Is there a way to make this conditional in the same way some of the other rules in addOptionalRules.js are?

GantMan commented 5 years ago

Regarding the report: Did you add it to the report function? here: https://github.com/infinitered/solidarity-react-native/blob/6ac49274db6478fc51e9dab07e66234c79320c2d/extensions/react-native.js#L60

Once you add to the report, I'll merge.

is343 commented 5 years ago

What do you need me to add to the report function? I'm a little confused on what you mean by that.

infinitered / solidarity-react-native

Fix basic rule logic, typo #32