infinitered / solidarity

Solidarity is an environment checker for project dependencies across multiple machines.
https://infinitered.github.io/solidarity/
MIT License
639 stars 48 forks source link

Typescript improvements #132

Closed GantMan closed 6 years ago

GantMan commented 6 years ago

Tagged Steve if he has a cycle. If not, will just merge bc yarn build works... and that's the real judge here, amirite? giphy-downsized 2

GantMan commented 6 years ago

o damnit tests!

codecov[bot] commented 6 years ago

Codecov Report

Merging #132 into master will decrease coverage by 0.27%. The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage    76.8%   76.53%   -0.28%     
==========================================
  Files          22       22              
  Lines         388      392       +4     
  Branches       73       74       +1     
==========================================
+ Hits          298      300       +2     
- Misses         66       67       +1     
- Partials       24       25       +1
Impacted Files Coverage Δ
src/extensions/functions/checkDir.ts 100% <100%> (ø) :arrow_up:
...extensions/functions/removeNonVersionCharacters.ts 100% <100%> (ø) :arrow_up:
src/extensions/functions/checkRequirement.ts 80.59% <100%> (ø) :arrow_up:
src/extensions/functions/getLineWithVersion.ts 83.33% <100%> (ø) :arrow_up:
src/extensions/solidarity-extension.ts 100% <100%> (ø) :arrow_up:
src/types.ts 100% <100%> (ø) :arrow_up:
src/extensions/functions/getVersion.ts 70% <100%> (ø) :arrow_up:
src/extensions/functions/checkCLIForUpdates.ts 89.47% <100%> (ø) :arrow_up:
src/extensions/functions/checkENV.ts 100% <100%> (ø) :arrow_up:
src/extensions/functions/checkFile.ts 100% <100%> (ø) :arrow_up:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d148d31...bd5d4f8. Read the comment docs.