search

infinitered / solidarity

Solidarity is an environment checker for project dependencies across multiple machines.
https://infinitered.github.io/solidarity/
MIT License
639 stars 49 forks source link

The --solidarityFile doesn't work (in the current version published to NPM) #224

Closed arizonatribe closed 5 years ago

arizonatribe commented 5 years ago

Currently you have 2.1.0 published to NPM, however the --solidarityFile flag does not work with this version (although it was corrected when that logic was extracted to the getSolidarityHelpers.ts file).

When will you be publishing what you have on Github to NPM so that this flag will work correctly?

arizonatribe commented 5 years ago

If it's going to be awhile (looks like 6 months since your last release) perhaps you could remove that --solidarityFile from the Solidarity docs since it doesn't work?

GantMan commented 5 years ago

I plan on releasing 3.0 soon :) maybe a month or so, would that be good?

arizonatribe commented 5 years ago

Yes that's fine. I'm trying to integrate solidarity into a forked version of react-scripts that will run before any build/start/test script is executed, and having a custom .solidarity per project would be ideal. For now I'm just doing a check if the engines prop from package.json that suffices

GantMan commented 5 years ago

Working on 3.0 today

GantMan commented 5 years ago

@arizonatribe - can you let me know if 2.3.1 fixed this? I released that version today.

GantMan commented 5 years ago

closing due to I'm sure 2.3.1 fixed this, and also, I'm about to release 3.0