infinitered / solidarity

Solidarity is an environment checker for project dependencies across multiple machines.

https://infinitered.github.io/solidarity/

MIT License

639 stars 49 forks source link

Support ~ in path with resolve-dir #238

Closed piecioshka closed 4 years ago

GantMan commented 5 years ago

Sorry for the delay, can you see about updating the tests to pass?

piecioshka commented 4 years ago

@GantMan Sorry for my delay. Everything should works.

I can't see that tests on Semaphore CI work, but on Travis is occur a problem with running them.

GantMan commented 4 years ago

@piecioshka - please resolve the conflict and tests should pass.

piecioshka commented 4 years ago

@GantMan Done.

Do you know what happen on Travis?

GantMan commented 4 years ago

No I do not. It has this error:

I'm gonna re-run it.

tabrindle commented 4 years ago

if you have that error, its because yarn has to update its lockfile, but --frozen-lockfile prevents it from doing so. A good idea on ci. The fix is simple - rerun yarn locally, and push the changes to the lockfile. Which makes sense here because the package.json was changed, and with no changes to yarn.lock

GantMan commented 4 years ago

@piecioshka - once this is merged, I'll release a new version.

codecov[bot] commented 4 years ago

Codecov Report

Merging #238 into master will increase coverage by 0.02%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   83.49%   83.52%   +0.02%     
==========================================
  Files          36       36              
  Lines         709      710       +1     
  Branches      139      139              
==========================================
+ Hits          592      593       +1     
  Misses         75       75              
  Partials       42       42

Impacted Files	Coverage Δ
src/extensions/functions/checkFile.ts	`87.50% <50.00%> (+1.78%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad56278...35adc29. Read the comment docs.

piecioshka commented 4 years ago

Hi @GantMan!

I updated yarn.lock file (what @tabrindle told). We cannot merge this PR because we have a problem with a new service that is used — codecov/patch

How can we resolve that issue?

GantMan commented 4 years ago

merged!