infinitered / solidarity

Solidarity is an environment checker for project dependencies across multiple machines.
https://infinitered.github.io/solidarity/
MIT License
639 stars 49 forks source link

Published JSON schema on json.schemastore.org is outdated #247

Closed shwanton closed 5 years ago

shwanton commented 5 years ago

The current published JSON schema does not reflect the latest 2.3.1 build

Most notably, shell and custom definition types are missing.

There is probably a version flag I'm missing, but this is the one that is published in the example

GantMan commented 5 years ago

you're right. Any interest in doing a PR?

shwanton commented 5 years ago

https://github.com/SchemaStore/schemastore/pull/785

It does bump the version to draft-07 so some links will have to be updated (assuming that's how the versioning works).

GantMan commented 5 years ago

very cool!!!

shwanton commented 5 years ago

https://github.com/SchemaStore/schemastore/pull/785#issuecomment-524923471

SchemaStore.org and its supporting editors doesn't support draft v7, so all schemas must be in draft v4 at this time

I'm not very familiar w/ JSON schema, will it cause other issues if we bump the draft version back to v4?

shwanton commented 5 years ago

@GantMan I have a commit to roll this back to draft-04, I just want to be sure it doesn't break anything before it's published to JSON schemastore.

GantMan commented 5 years ago

Should be all good.

shwanton commented 5 years ago

Merged! https://github.com/SchemaStore/schemastore/pull/785#issuecomment-524923471