search

infinitered / solidarity

Solidarity is an environment checker for project dependencies across multiple machines.
https://infinitered.github.io/solidarity/
MIT License
639 stars 49 forks source link

fix custom error bug, add test, fix typo, refactor test #257

Closed mishra-ankit closed 4 years ago

mishra-ankit commented 4 years ago

Fix #256, added test and refactor some tests around custom errors

GantMan commented 4 years ago

Restarting Travis CI

GantMan commented 4 years ago

It appears the Danger test is failing. Can you please comment out https://github.com/infinitered/solidarity/blob/master/.travis.yml#L11

And this will pass. I'll see about the danger tests later.

mishra-ankit commented 4 years ago

@GantMan Commented out for now. Hope it passes this time.

codecov[bot] commented 4 years ago

Codecov Report

Merging #257 into master will increase coverage by 0.47%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   83.02%   83.49%   +0.47%     
==========================================
  Files          36       36              
  Lines         707      709       +2     
  Branches      137      139       +2     
==========================================
+ Hits          587      592       +5     
+ Misses         77       75       -2     
+ Partials       43       42       -1
Impacted Files Coverage Δ
src/extensions/functions/checkDir.ts 85.71% <100.00%> (+2.38%) :arrow_up:
src/extensions/functions/checkFile.ts 85.71% <100.00%> (+2.38%) :arrow_up:
src/extensions/functions/checkRequirement.ts 85.48% <0.00%> (+4.83%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f4006e...1425276. Read the comment docs.

mishra-ankit commented 4 years ago

@GantMan Thanks! Wondering what's the release cycle here ? When can one expect this to be available on npm ?

GantMan commented 4 years ago

I believe there's one more PR in the works and we're pushing after that.

https://github.com/infinitered/solidarity/pull/238

mishra-ankit commented 4 years ago

Sounds good. Thanks!

haakemon commented 3 years ago

@GantMan This issue is blocking us from upgrading to version 3. Any chance of a new release with this included?

GantMan commented 3 years ago

I just published 3.0.1