search

infinity0 / mozilla-gnome-keyring-legacy

A firefox extension that enables Gnome Keyring integration (legacy version)
https://bugzilla.mozilla.org/show_bug.cgi?id=309807
Other
55 stars 8 forks source link

Ignore Bugfix releases for minVersion #15

Closed fat-lobyte closed 12 years ago

fat-lobyte commented 12 years ago

Bugfix releases (third component of the version number) will be ignored for the minimum XULRunner version.

Any version number components starting from the third component will be stripped for the minimum version number.

Technically this is wrong, because the ABI version is not backwards compatible (an extension compiled against 14.0.1 is not supposed to run with 14.0.0). However, I'm pretty sure they won't break ABI in a small bugfix release.

What is a big problem however, is that sometimes they release Firefox with a version number higher than Thunderbird (like right now 14.0.1 Firefox but 14.0 Thunderbird), although it's mostly the same XULRunner version. This used to break the extension until the Firefox and Thunderbird versions happened to match.

Do you think this patch is a good Idea? I'm just tired of forcing the version number down to *.0 manually in the distribution packages.

ps.: If you decide to merge, could you do it without a merge commit? I think it's a shame cluttering up history for just a single commit, especially if it's fast-forward.

infinity0 commented 12 years ago

sounds good, the scenario you describe is probably the most common use case. if someone does need to revert to the old behaviour, they can still override XUL_VER_MIN through the usual means.

fat-lobyte commented 12 years ago

Thanks for the merge.