search

infinity0 / mozilla-gnome-keyring-legacy

A firefox extension that enables Gnome Keyring integration (legacy version)
https://bugzilla.mozilla.org/show_bug.cgi?id=309807
Other
55 stars 8 forks source link

does not work on xulrunner 14 #16

Closed elukas912 closed 12 years ago

elukas912 commented 12 years ago

When running firefox 14 on debian x86-64 with xulrunner 14, mozilla-gnome-keyring does not work. The old password prompt shows up instead of asking for the gnome-keyring password

fat-lobyte commented 12 years ago

Please include the following information:

elukas912 commented 12 years ago

Firefox Version: 14.0.1, mozilla-gnome-keyring version is from the zip-download: mozilla-gnome-keyring-0.6.3-2, The extension is enabled, but there is no effect on the password manager, the output of make is:

g++ xpcom_abi.cpp -o xpcom_abi pkg-config --cflags libxul pkg-config --libs libxul -Wlpkg-config --libs-only-L libxul | sed -e 's/-L\(\S*\).*/,-rpath=\1/' -Wall -fno-rtti -fno-exceptions -fPIC -std=gnu++0x make mozilla-gnome-keyring-dev-1343830505.xpi PLATFORM=./xpcom_abi || echo unknown Segmentation fault make[1]: Entering directory /home/p/Downloads/infinity0-mozilla-gnome-keyring-5f97761' g++ GnomeKeyring.cpp -o libgnomekeyring.so -shared \ pkg-config --cflags libxul`pkg-config --libs libxul pkg-config --cflags gnome-keyring-1 pkg-config --libs gnome-keyring-1 -Wall -fno-rtti -fno-exceptions -fPIC -std=gnu++0x GnomeKeyring.cpp: In member function ‘virtual nsrefcnt GnomeKeyring::Release()’: GnomeKeyring.cpp:560:1: warning: deleting object of polymorphic class type ‘GnomeKeyring’ which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor] chmod +x libgnomekeyring.so mkdir -p xpi/platform/unknown/components cp -a libgnomekeyring.so xpi/platform/unknown/components/libgnomekeyring.so mkdir -p xpi XUL_VER_MIN=echo 14.0.1 | sed -r -e 's/([^.]+\.[^.]+).*/\1/g'; \ XUL_VER_MAX=echo 14.0.1 | sed -rn -e 's/([^.]+).*/\1.*/gp'; \ sed -e 's ${PLATFORM} 'unknown' g' \ -e 's ${VERSION} 'dev-1343830505' g' \ -e 's ${XUL_VER_MIN} '"${XUL_VER_MIN:-10.0.1}"' g' \ -e 's ${XUL_VER_MAX} '"${XUL_VER_MAX:-10.}"' g' \ install.rdf > xpi/install.rdf mkdir -p xpi sed -e 's/${PLATFORM}/'unknown'/g' \ chrome.manifest > xpi/chrome.manifest cd xpi && zip -rq ../mozilla-gnome-keyring-dev-1343830505.xpi make[1]: Leaving directory `/home/p/Downloads/infinity0-mozilla-gnome-keyring-5f97761'

I had to change em:targetPlatformunknown/em:targetPlatform to em:targetPlatformLinux/em:targetPlatform in the install.rdf file to convice Firefox that this extension is for him.

fat-lobyte commented 12 years ago

This bug is a duplicate of Issue #12, and not exactly our fault (see Mozilla bug https://bugzilla.mozilla.org/show_bug.cgi?id=763327).

Until Mozilla has fixed this bug, you can use the following branch as a workaround: https://github.com/fat-lobyte/mozilla-gnome-keyring/tree/hashbytes-workaround (fat-lobyte/mozilla-gnome-keyring@655796fc259ecd1473e6a3cedf0eb75fbfa5595a)

elukas912 commented 12 years ago

thank you very much for the quick solution!