search

infinity0 / mozilla-gnome-keyring-legacy

A firefox extension that enables Gnome Keyring integration (legacy version)
https://bugzilla.mozilla.org/show_bug.cgi?id=309807
Other
55 stars 8 forks source link

"show passwords" prompts user to unlock every keyring #2

Open infinity0 opened 12 years ago

infinity0 commented 12 years ago

(as opposed to just the keyring for the current firefox profile)

If you cancel any of these requests, no passwords are returned. This is wrong; ideally the user should not be prompted at all, but if this is unavoidable then at least cancellation of an unrelated keyring should not abort the entire process.

"show site exceptions" does not exhibit this behaviour, which is correct. "auto-complete" also does not exhibit this behaviour, which is correct.

infinity0 commented 12 years ago

unfortunately, "auto-complete" does exhibit this behaviour in certain cases, i.e. when the other keyrings contain a MATCH for the current domain to be auto-completed on.

infinity0 commented 12 years ago

the GNOME search functionality does not allow searching by keyring. currently we are getting results from all keyrings back, then filtering by keyring ourselves. unfortunately, GnomeKeyringFound contains char* secret as a field, which means that this is already filled out (and the user prompted to unlock any matching entries from other keyrings) before control passes to us.

http://developer.gnome.org/gnome-keyring/unstable/gnome-keyring-Search-Functionality.html#GnomeKeyringFound

infinity0 commented 12 years ago

libsecret (the successor to libgnome-keyring) will allow this.

https://bugzilla.gnome.org/show_bug.cgi?id=672356