Prevent a.out creation, add default pref and icon

infinity0 / mozilla-gnome-keyring-legacy

A firefox extension that enables Gnome Keyring integration (legacy version)

https://bugzilla.mozilla.org/show_bug.cgi?id=309807

Other

55 stars 8 forks source link

Prevent a.out creation, add default pref and icon #24

Closed gentoo90 closed 11 years ago

gentoo90 commented 11 years ago

Fix NEED_HASHFUNC to write to /dev/null, not a.out
Add default value for extensions.gnome-keyring.keyringName so user don't have to create it by hand
Add extension SVG-icon (from Seahorse)

infinity0 commented 11 years ago

would a SVG work as well? if so, could you replace the PNG with it? preferably, undo 9ae5b5b and create a new one on top of 1880b9e.

gentoo90 commented 11 years ago

Tested on Gentoo x64 with Firefox 15.0.1. Also ebuild is available in gentoo's bugzilla

infinity0 commented 11 years ago

This is excellent, thanks a lot! :D One additional thing is to add copyright information for that seahorse graphic. I can do this myself, but could you confirm that the following information is correct, or if you want to be attributed by a different name:

seahorse.svg was created by gento90[1] cropping data/icons/svg/seahorse.svg[2] from the GNOME seahorse git repository, and is distributed under GPL v2 or later.

[1] https://github.com/gentoo90 [2] http://git.gnome.org/browse/seahorse/tree/data/icons/svg/seahorse.svg

gentoo90 commented 11 years ago

http://git.gnome.org/browse/seahorse/tree/data/icons/svg/seahorse.svg is other icon from newer release: svg1 I used icon from 2.32 tag http://git.gnome.org/browse/seahorse/tree/data/icons/svg/seahorse.svg?h=gnome-2-32 svg

infinity0 commented 11 years ago

Thanks, merged.