Fails to build with XULRunner 9

fat-lobyte commented 12 years ago

Fails to build with XULRunner 9 on Fedora 16 with GCC 4.6.2.

 $ make
test -n libxul || { echo "libxul missing" && false; }
g++ GnomeKeyring.cpp -g -Wall -o libgnomekeyring.so \
    `pkg-config --cflags libxul gnome-keyring-1` -DMOZ_NO_MOZALLOC `pkg-config --libs libxul | sed 's/xpcomglue_s/xpcomglue_s_nomozalloc/' | sed 's/-lmozalloc//'` `pkg-config --libs gnome-keyring-1` -fno-rtti -fno-exceptions -shared -fPIC -g -std=gnu++0x \

/usr/include/xulrunner-sdk-2/nsISupportsBase.h: In function 'nsILoginInfo* foundToLoginInfo(GnomeKeyringFound*)':
/usr/include/xulrunner-sdk-2/nsISupportsBase.h:94:25: error: 'virtual nsrefcnt nsISupports::AddRef()' is inaccessible
GnomeKeyring.cpp:482:3: error: within this context
make: *** [libgnomekeyring.so] Error 1

The XUL version is:

$ rpm -q xulrunner-devel
xulrunner-devel-9.0-2.fc16.x86_64

The offending Line is: GnomeKeyring.cpp:482:

infinity0 commented 12 years ago

should be fixed by 9f060f1ce71263a8f34dbe0fbe815b93336e89d9

please test though - it compiles for me but i haven't had a chance to test yet

infinity0 commented 12 years ago

ah, I just saw Mic92/firefox-gnome-keyring@c487221e1ad122f2e093c1e67f029808c7c74510 - will use that instead

infinity0 commented 12 years ago

tested on iceweasel 9 and everything seems to work as before - closing.

fat-lobyte commented 12 years ago

Ok, thanks, seems to work and no new regressions visible.

infinity0 / mozilla-gnome-keyring-legacy

Fails to build with XULRunner 9 #3