search

infinity0 / mozilla-gnome-keyring-legacy

A firefox extension that enables Gnome Keyring integration (legacy version)
https://bugzilla.mozilla.org/show_bug.cgi?id=309807
Other
55 stars 8 forks source link

Patch for xulrunner-18 #30

Closed lepokle closed 11 years ago

infinity0 commented 11 years ago

I've cherry-picked and squashed 09bcaad and d1feca1 into de4d7c9. Please make your pull requests as neat as that in the future, i.e. containing no extra cruft.

jglick commented 11 years ago

FYI: I recently updated to xul-ext-gnome-keyring 0.6.6~git20130111-0ubuntu1 (which I guess resulted from this pull request?) on Ubuntu 12.04 and this seems to have broken operation with thunderbird 17.0.2+build1-0ubuntu0.12.04.1. I have plugin add-on compatibility checks suppressed, so the plugin is marked as enabled, but I am prompted for a master password nonetheless.

Unfortunately (@fat-lobyte) http://ppa.launchpad.net/fat-lobyte9/ppa-public/ubuntu/pool/main/m/mozilla-gnome-keyring/ seems to lack xul-ext-gnome-keyring 0.6.5-0ubuntu1 and my /var/cache/apt/archives/ lacks it too. Fortunately Googling found me https://launchpad.net/~fat-lobyte9/+archive/ppa-private/+build/4007213/+files/xul-ext-gnome-keyring_0.6.5-0ubuntu1_i386.deb which seems to be working again.

Time to hold some packages I guess.

fat-lobyte commented 11 years ago

@jglick Yes, this is a problem. I updated it, because I thought that things were going on "as usual", which means that Firefox updates, and a few days later, Thunderbird does too.

This time, this is not the case! Thunderbird will be frozen at TB 17 and the next Release is scheduled as TB 24 while Firefox keeps getting the regular updates.

Debian (aka @infinity0) currently builds two packages (one for Firefox, one for Thunderbird) because of version mismatches between Firefox and Thunderbird in Debian. For Ubuntu this has not been necessary - up until now.

I think I will rebase the package against the Debian package, and build two packages instead. Kind of sucks, but what're you gonna do.

ps.: There's got to be another way. I'm tired of manually updating, fixing build failures, being pissed at Ubuntu/Mozilla. What would be really awesome is an extension that has the same functionality, but does not need to be built into a binary. Maybe we can fix something up with DBUS-Magic. We'll see.

pps.: Thanks for posting here, in a public forum and not mailing me directly. It makes much more sense.

fat-lobyte commented 11 years ago

@jglick: This should be fixed in 0.6.7-1ubuntu1.

Kudos go to infinity0 for the perfect Debian package. Please address any future issues concerning the Ubuntu package in the (newly created) issue tracker of my repository: https://github.com/fat-lobyte/mozilla-gnome-keyring/issues

jglick commented 11 years ago

@fat-lobyte it is possible to access the keyring using DBUS though tricky. I have tried doing this using qdbus without success, since (unless patched) it cannot handle sessions, and this API requires two steps for any operation. gdbus has a --session option, which the man page does not document, but if it is the same as for dbus-send then it is useless.

jglick commented 11 years ago

By the way 0.6.7-1ubuntu1 seems to be working, thanks.

infinity0 commented 11 years ago

libsecret, the successor to libgnome-keyring, has a javascript API: http://people.gnome.org/~stefw/libsecret-docs/ - although I have no idea how to access it from inside an XUL extension.

this would fix issue #23 too, although i was originally thinking of C++ for that.