search

infinity0 / mozilla-gnome-keyring-legacy

A firefox extension that enables Gnome Keyring integration (legacy version)
https://bugzilla.mozilla.org/show_bug.cgi?id=309807
Other
55 stars 8 forks source link

Fix FTBFS with Firefox 19 #32

Closed fat-lobyte closed 11 years ago

fat-lobyte commented 11 years ago

Hi, this fixes the build failure with Firefox 19.

Since Gecko 19, the type "nsresult" is not an integer, but an enum class. This causes compiler errors when returning the nsresult from a function.

By wrapping nsresult in the NS_ERROR_GET_CODE() macro, we can retrieve the numerical value of the error code.

Regards, fat-lobyte

infinity0 commented 11 years ago

Thanks! I also pushed another commit on top of this, which tweaks your previous pull request so that compiling for 10.0 still works (since Debian testing is still using this version, sigh).

infinity0 commented 11 years ago

Also, see http://mikegerwitz.com/docs/git-horror-story.html for how to PGP sign your git commits. My last commit 32f04a6a2377e5af354120c1a64b9ec4f9e8eef1 is my first published signed commit. :) git log --show-signature to view and verify.

fat-lobyte commented 11 years ago

Ok, I will do that for commits intended to be merged. While we're at it, could you please sign the version tags? Either I'm too stupid to download them or you haven't signed them yet.

infinity0 commented 11 years ago

You're right, I've been using unannotated tags. I'll push some signed annotated ones as soon as I can.