infinity0 / mozilla-gnome-keyring-legacy

A firefox extension that enables Gnome Keyring integration (legacy version)
https://bugzilla.mozilla.org/show_bug.cgi?id=309807
Other
55 stars 8 forks source link

Does not work in Thunderbird ? #39

Closed alci63 closed 10 years ago

alci63 commented 10 years ago

Hi,

I have compiled the latest version from git master with xulrunner-sdk 23.0. I have installed it in Fireofx 23, on Ubuntu 13.04. This worked fine.

Then I tried to install in Thunderbird, which happens to be version 17.0.8 in Ubuntu 13.04. First, TB told me the extension was not compatible. I changed the install.rdf in the xpi to allow wulrunner version 17 to 23 in Thunderbird. Extension installed, but does not work (I am asked for my master password).

So, should I compile against another version of xulrunner-sdk ? Or is there a problem with TB and latest version of the extension ?

thanks

infinity0 commented 10 years ago

might this be related to #26?

alci63 commented 10 years ago

well, I don't think so. #26 is about packaging on Ubuntu, which seems to be very inconvienient since xulrunner-dev does not ship anymore, and firefox-dev + thunderbird-dev are incomplete.

What I did is manually download xulrunner-sdk (23.0), and compile using the following command line given by swick :

XUL_CFLAGS="-I../../xulrunner-sdk/include -I../../xulrunner-sdk/include/nspr" XUL_LDFLAGS="-L../../xulrunner-sdk/lib -lxpcomglue_s -lxul -lmozalloc -lplds4 -lplc4 -lnspr4 -lpthread -ldl" XPCOM_ABI_FLAGS="-Wl,-rpath=/usr/lib/firefox" make

This produced a xpi that works just fine with Firefox 23 on Ubuntu 13.04.

My problem is that the same xpi does not work with TB: 1) unchanged, TB complains that the extension is not compatible 2) after changing

em:targetApplicationem:id{3550f703-e582-4d05-9a08-453d09bdfdc6}/em:idem:minVersion23.0/em:minVersionem:maxVersion23.*/em:maxVersion/em:targetApplication to em:targetApplicationem:id{3550f703-e582-4d05-9a08-453d09bdfdc6}/em:idem:minVersion17.0/em:minVersionem:maxVersion23.*/em:maxVersion/em:targetApplication (minVersion 23.0 to 17.0) in install.rdf and recreating the xpi zip, TB accepts the extension, but still asks for the main password. Hence my question: does the lastest version work with TB version 17 ? Am I supposed to compile using an older xulrunner-sdk, or is changing the minVersion ok ?
infinity0 commented 10 years ago

apologies, I have now had a more detailed read through what you wrote.

"1) TB complains that the extension is not compatible" - this is expected if you built with only xulrunner-dev 23, since it does not know that thunderbird is at version 17. to build separate versions for firefox/thunderbird you will need to install both -dev packages and (if it still works for ubuntu) check out the "ubuntu" branch from @fat-lobyte's fork and run something like (I am guessing) gbp buildpackage --git-upstream-branch=master --git-debian-branch=ubuntu --git-upstream-tree=branch from the git-buildpackage package.

"2) ... accepts the extension, but still asks for the main password." - this is firefox/thunderbird's problem and is covered in the README.

So I don't think there is actually a bug here and everything you experienced is expected behaviour (or at least very very infeasible to "fix".) I will close if you agree.

alci63 commented 10 years ago

1) Thanks for the information. I will study what gbp does. I have to do my home work now :-)

Regarding point 2), I guess you are refering to the fact that TB asks for the master password to unlock the private ssl keys? It used to asked for them when I was sending a signed email. Now, it is asking for the master password as soon as I open TB. That's why I think it does not work in TB. That said, having to type in the master password once on launching is not less convinient than to enter it each time I need to send a (signed) mail... I guess I'll live with this. I close the ticket.

infinity0 commented 10 years ago

In that case, it would appear that thunderbird is confused and tries to unlock the internal "master password" (for the SSL keys) even though it only needs passwords from gnome-keyring. It is not something that this extension can control. Perhaps you could file a bug to those guys, it sounds like it is more their problem.