infinity0 / mozilla-gnome-keyring-legacy

A firefox extension that enables Gnome Keyring integration (legacy version)
https://bugzilla.mozilla.org/show_bug.cgi?id=309807
Other
55 stars 8 forks source link

Extension broken with FF 25 ? #41

Closed alci63 closed 10 years ago

alci63 commented 10 years ago

Hi,

I just upgraded to FF 25. I compiled from source with xulrunner 25, and installed the plugin. This went fine, but... the plugin does not seem to work.

Not login / password is proposed. In fact, openning Firefox does not unlock the 'mozilla' keyring in Seahorse.

Did anyone try the plugin on FF25 ? Is it supposed to work ? What should check ?

infinity0 commented 10 years ago

Did you install the xulrunner-dev package at version 25? See #40.

alci63 commented 10 years ago

I did compile directly from source, that is:

  1. clone mozilla-gnome-keyring
  2. apt-get install libgnome-keyring-dev
  3. get xulrunner-sdk version 25.0 from ftp.mozilla.org and unpack it
  4. compile using:

XUL_CFLAGS="-I../xulrunner-sdk-25/include -I../xulrunner-sdk-25/include/nspr" XUL_LDFLAGS="-L../xulrunner-sdk-25/lib -lxpcomglue_s -lxul -lmozalloc -lplds4 -lplc4 -lnspr4 -lpthread -ldl" XPCOM_ABI_FLAGS="-Wl,-rpath=/usr/lib/firefox" make

This is on Ubuntu, so there is no xulrunner-dev package, that's why I use the xulrunner-sdk directly from mozilla.

This method went fine for V23 as well as V24... For v25, compilation went fine, a .xpi was produced and I could install it in Firefox without a problem. But the keyrng is not unlocked (nor used).

infinity0 commented 10 years ago

What does minVersion/maxVersion in install.rdf inside the xpi say? (xpi is just a zip file, you can rename it to .zip and extract it)

Were there any warnings during the build process?

Start firefox from a terminal, is there any error output?

alci63 commented 10 years ago

Min max version says:

em:minVersion25.0/em:minVersion em:maxVersion25.*/em:maxVersion

When running from terminal, I get these messages (but I think it is unrelated):

franck@franck-ThinkPad-T430s:~$ firefox

(process:30998): GLib-CRITICAL **: g_slice_set_config: assertion 'sys_page_size == 0' failed

(firefox:30998): GLib-GObject-WARNING **: Attempt to add property GnomeProgram::sm-connect after class was initialised

(firefox:30998): GLib-GObject-WARNING **: Attempt to add property GnomeProgram::show-crash-dialog after class was initialised

(firefox:30998): GLib-GObject-WARNING **: Attempt to add property GnomeProgram::display after class was initialised

(firefox:30998): GLib-GObject-WARNING **: Attempt to add property GnomeProgram::default-icon after class was initialised Running global cleanup code from study base classes.

alci63 commented 10 years ago

As a side note, I also tried the plugin on a freshly installed VM (Ubuntu 13.10), with FF 25, and I get the same result: extension is installed, no error (that I see), but the extension seems to be just ignored. No mozilla keyring is created, and remembering passwords creates them in the Firefox password manager.

alci63 commented 10 years ago

Is there a way to get an extensive log from the plugin, to try to find what happens ?

infinity0 commented 10 years ago

Er you can try adding print statements (or even log functions if they're available, I'm not familiar with the XPCOM framework) to the C++ code and see which parts are getting called. I'll have time to take a look myself hopefully within the next two weeks.

alci63 commented 10 years ago

I manage to make it work in Firefox. I had to uninstall the extension completely, and reinstall it, until FF realized it was here. But it now works. I'm not expert enough to tell what happened, and why upgrading the already installed extension did not work... (nb: I couldn't make it work in Thunderbird)

infinity0 commented 10 years ago

Oh yes, I've seen that problem before. Sometimes it fixes itself if I go into about:addons and click "Details" for the extension, then restart the browser. Maybe try that for Thunderbird?

jcharaoui commented 10 years ago

I have a similar problem on Debian testing/sid, where I upgraded from Icedove 17 to 24. I rebuilt the extension using the proper dependencies, so it loads up fine, but does nothing. I've tried creating a new, empty profile, but the default password manager is still used.

infinity0 commented 10 years ago

Icedove 24 is affected by this which is specific to icedove 24, and is a separate issue from OP.

jcharaoui commented 10 years ago

Right, that's the one, sorry about that.

infinity0 commented 10 years ago

@alci63 I'm closing this bug because it was fixed for you and it sounded like a problem with how Firefox handles upgraded extensions. Please voice if you think it should remain open.