search

infinity0 / mozilla-gnome-keyring-legacy

A firefox extension that enables Gnome Keyring integration (legacy version)
https://bugzilla.mozilla.org/show_bug.cgi?id=309807
Other
55 stars 8 forks source link

pure JavaScript implementation #43

Open swick opened 10 years ago

swick commented 10 years ago

Hey, I was so pissed that the addon broke with the latest firefox update again because I wanted to do some work and I first had to fix the damn thing. That's why I decided that we need something better and I began working on a pure JavaScript implementation of this addon. No more SDK downloads, no more re-compiling, no more random breakage.

There still is a bug with the password field not being filled out when there are multiple login options available but other than that it should all work. It's also compatible with everything from the C++ implementation.

I would like some testing (and please backup your keyring - this is experimental stuff). You can find the addon here https://github.com/swick/moz-gnome-keyring-integration

edit: I fixed some bugs and now it is working pretty good for me. You can download it directly from mozilla.org https://addons.mozilla.org/en-US/firefox/addon/gnome-keyring-integration-1

infinity0 commented 10 years ago

Thanks very much, I shall put this on my todo-list to review.

Do you have an idea on what would be causing the multiple-options bug? It is fairly important, but I would hope that if you followed the loginManagerStorage interface things would just work as normal.

(There is also #2 but that is a fundamental limitation of gnome keyring.)

swick commented 10 years ago

The multiple options bug is fixed. I forgot to implement isLoggedIn which somehow caused this behavior. There are still things left to do like error handling when searching libgnome-keyring.so, improving the logic to unlock the keyring and stuff like that.

infinity0 commented 10 years ago

BTW, since you are rewriting everything, do you think you could use libsecret instead of libgnome-keyring? That would work for KDE keyring too, I believe. There is more information about it in #23 and https://bugzilla.gnome.org/show_bug.cgi?id=672356.