Closed AndreasA closed 9 years ago
It seems like they modified the nsILoginManagerStorage.h the initWithFile method seems to have been removed completely and the Init Method looks now like this: NS_IMETHOD Initialize(JS::MutableHandleValue _retval) = 0;
GetAllEncryptedLogins seems also to have been removed
I have just created a pull request which fixes the this problem: https://github.com/infinity0/mozilla-gnome-keyring/pull/47
I tried to compile the fix with v31.0 and v32.0 and both work correctly (also installed and checked if I can access the passwords).
What I have not added is support for the new last used / stored timestamps.
Thanks! I will try to review and merge this in the next week.
Should be fixed. I simplified the code to remove support for older versions.
I'll note now that our Initialize
isn't conformant to the new IDL; we are supposed to return a "Promise" JS object, but I don't know how to do that from C++. In practise I don't think it is a problem though, but eventually we should move to swick's JS implementation (#43) when that is ready.
I think that is in general a good idea. It should not require to be recompiled for every version that way, shouldn't it?
Recompiled no, but a new version might still break it. For example the Init
-> Initialize
change here, requires changes in JS too, e.g. see swick/moz-gnome-keyring-integration@f0423833b839a4ffcbf442f5822a023e05861cef However more trivial changes such as the PRUnichar
-> char16_t
around version 29/30 (can't remember which) should not affect JS.
Hi,
I cannot compile it against the v32.0 SDK, I get the following output: