search

infinity0 / mozilla-gnome-keyring-legacy

A firefox extension that enables Gnome Keyring integration (legacy version)
https://bugzilla.mozilla.org/show_bug.cgi?id=309807
Other
55 stars 8 forks source link

[BUG] Firefox v33.0 compiles but does not work #48

Open AndreasA opened 9 years ago

AndreasA commented 9 years ago

With Firefox v33.0 the extension still seems to compile but it does not work (no users listed if I go to stored password).

I have now switched to the JS implementation as that one still works.

infinity0 commented 9 years ago

This has been an issue on previous upgrades and usually things fix by themselves. Can you test from a new profile?

AndreasA commented 9 years ago

Tried a new profile and still did not work

simontunnat commented 9 years ago

I'm having the same problem.

infinity0 commented 9 years ago

I don't have much free time at the moment, it will take me maybe a few months to get to this... I encourage people to try swick's JS version and help him fix bugs and any incompatibilites with this extension. At some point I will retire this one and switch to that.

dffischer commented 9 years ago

Swick's pure Javascript implementation works great and clearly progresses into the right direction. I packaged it for ArchLinux, which up to now had many variants of your plugin. Users of the following packages may want to switch:

Do you consider swick's variant to be mature enough to replace your version? I would then try to merge the vast number of packages under the new name.

infinity0 commented 9 years ago

I haven't yet used it. I'll replace my version with his (including redoing the Debian packaging etc) when I've gone through and systematically tested all functionality. It would help if someone made a checklist of things to test - I'll be happy to trust statements like "I've tested saving a new password on a web form against FX33", or "I've tested updating a saved password on TB33 where the same data exists in a different keyring, and only the correct keyring was updated", but "works great" is too vague to rely on here.

AndreasA commented 9 years ago

As far as I can tell the JS implementation still has some issues: For instance, replace password does not work for me at all (there is a ticket). List of passwords currently only shows some and not all passwords (I actually think this is a regression because that worked once). Loading of password is slower than with binary. One also gets the replace password message if there is nothing to replace.

Created corresponding tickets for those issues but they are still open.

What about the FX33+ compilation of the binary version? Does it work correctly again with FX35?