Open Wolf1098 opened 5 months ago
I've encountered the same error using the plugin on different machines, similarly with multiple domains and wildcards. I've installed this plugin from source in one case, through the Arch User Repository build script in another and none of the components are containerized.
This isn't a critical error if it happens a couple of times but the renewal process can fail if there are too many TXT records that haven't been cleaned up as no more can be created after a point.
Nor sure where the problem is exactly as making API deletion calls using curl directly or pkb-client directly works as expected.
The issue is that it's using the object variable _self._root_domain
except that's a variable that changes for every validation. And in our case, we're using 2 different domain names, and so it's attempting to delete the record off of the wrong domain name.
i.e.
domain1.com
, *.domain1.com
, domain2.com
, *.domain2.com
1,2,3,4 recordIDs respectively
It's attempting to delete the recordID 1 from domain2.com
The fix is pretty simple. I'll open a PR
Describe the bug The acme_challenge records do not get removed once validated.
To Reproduce Unknown... I have both wildcard and root domains on 1 line with extra -d options????
Expected behavior The porkbun api doesn't seem to be cleanly handling the delete dns records... unsure why
Certbot command Docker Compose File
Versions (please complete the following version information):
2.4.0
docker: infinityofspace/certbot_dns_porkbun:latest Platform linux/arm64/v8 ``(sha256:9a65965e4a72d37cf2c99740291e46a579f4b91f1b31188b93f2e94354883a2c)
Error message
Additional context I have 8 domains using the san feature, 4 of which are the root domains, and 4 are wildcards for the subdomains