search

infinitytec / blocklists

A collection of hosts files and filter lists to make the world a better place.
MIT License
29 stars 4 forks source link

How should I implement wildcards? #13

Open infinitytec opened 1 year ago

infinitytec commented 1 year ago

With the release of Pi-hole FTL 5.22, we can now use Adblock Plus-style filters to block subdomains!

Pretty neat, and I intend on implementing this in some way.

Some possible ways this can be done:

  1. Simplify the lists using ABP formats as much as possible. Remove as many subdomains as possible from the lists. This would make lists a lot smaller, which could improve performance. However this may make lists incompatible with blockers other than Pi-hole, uBlock Origin, and Adblock Plus.
  2. Create new lists specifically for wildcards. I would probably only create it for domains that frequently create tons of subdomains. The domain lists would continue as they currently are. A possible problem with this is adoption being slower if people are unaware of these new files.
  3. Add the wildcards to the lists. This would offer the best of both worlds at the expense of slightly larger lists and possibly throwing some errors in some blockers. I know that Pi-hole will typically just throw out malformed lines, but I don't know about any other blockers, which could cause problems.

I'm leaning towards the second option, as it offers the greatest resiliency against breakage. I'd love to get some feedback from users as to how this should be handled.

infinitytec commented 1 year ago

Currently I am planning on adding them to the existing files.